Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to build both static and shared libraries #595

Merged
merged 5 commits into from
May 8, 2020

Conversation

dota17
Copy link
Member

@dota17 dota17 commented May 6, 2020

@coveralls
Copy link

coveralls commented May 6, 2020

Coverage Status

Coverage decreased (-0.2%) to 85.768% when pulling 70afc2b on dota17:static_shared into 8e3d3d5 on json-c:master.

@dota17
Copy link
Member Author

dota17 commented May 6, 2020

Allow to build both static and shared libraries.

cmake -DBUILD_STATIC_LIBS=ON ..

@hawicz
Copy link
Member

hawicz commented May 7, 2020

We should default to both static and shared being built, and describe -DBUILD_SHARED_LIBS=OFF and -DBUILD_STATIC_LIBS=OFF as simply turning the relevant build off, rather than having it say it turns the "other" libs build on.

@dota17
Copy link
Member Author

dota17 commented May 7, 2020

ok

@hofnarrr
Copy link
Contributor

hofnarrr commented May 7, 2020

Hi, there is some problems with the fix this branch provides. Not sure what's the "correct" way to submit fixes to other people's PR's, so I submitted a pull request to dota17's branch (dota17#90).

@dota17
Copy link
Member Author

dota17 commented May 8, 2020

@hofnarrr Thanks a lot! I found the install error of share&static libraries before and was thinking how to fix it. Your fixs are very timely, ha-ha.

@hawicz hawicz merged commit 22870ac into json-c:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants