Make json_object_object_add() indicate success or failure, test fix #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Return value of json_object_object_add() changed from void to int. Return value now indicates success or failure. * Check whether allocations are successful. * Do not exit program from within the library.
|
I'm mostly convinced that changing the return value from void to int won't change the ABI (see http://stackoverflow.com/questions/15626579/c-abi-is-it-safe-to-change-void-function-to-return-int) so this change should be merged. At this point, I'll need to merge it by hand. The fix to test_parse has already been applied. |
|
ugh, there's is some pretty bogus use of goto's in this change. :( |
|
After dealing with the steaming pile that is git, I finally managed to get the change to json_object_object_add manually merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_object_object_add() now indicates success or failure via its return value. The previous behaviour, namely to exit the program on failure, is cumbersome in large-scale applications.
Note that the change of return value from void to int may break the ABI so that programs using json-c may have to be rebuilt.
Unrelated to this change, I found I had to adjust the expected output of test_parse for a successful build.