Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat fixes #627

Closed
wants to merge 1 commit into from
Closed

Compat fixes #627

wants to merge 1 commit into from

Conversation

sherpya
Copy link
Contributor

@sherpya sherpya commented Jun 1, 2020

there is no need to call CryptAcquireContextW because two string parameters are NULL
CryptAcquireContextW does not work on Win98, and CRYPT_SILENT flags is not supported on WInNT4 and Win98x, any info about WIn2k?

I'm returning the fallback function, if you don't like it it can be reverted, but anyway is a bad pratice to call exit() inside a library

@sherpya sherpya changed the base branch from master to json-c-0.14 June 1, 2020 18:54
@sherpya
Copy link
Contributor Author

sherpya commented Jun 1, 2020

do you prefer also against master?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.758% when pulling 5bb5842 on clamwin:compat-fixes into 4467e94 on json-c:json-c-0.14.

@hawicz
Copy link
Member

hawicz commented Jun 3, 2020

Yes, if you could re-spin this against master that would be preferred, since this isn't a 0.14-specific change.
Also, I'm expecting to release a 0.15 version before a 0.14.1 (if at all), so it might not be worth pulling over to the 0.14 branch at all.

@sherpya sherpya closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants