Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmake version for tests #726

Merged
merged 1 commit into from Oct 9, 2021
Merged

fix cmake version for tests #726

merged 1 commit into from Oct 9, 2021

Conversation

leongross
Copy link
Contributor

When compiling the project an error is thrown:

CMake Error at tests/CMakeLists.txt:48 (target_sources):
  Unknown CMake command "target_sources".

This is due to the cmake option target_sources introduced in CMake version 3.1.
I suggest to add the minimum required version in the CMake file for the test.
Also I added a notion in the main README.md

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.444% when pulling 8be2ffd on leongross:fix/test-cmake3.1 into 4fc44f3 on json-c:master.

@hawicz hawicz merged commit 382f946 into json-c:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants