Preserve context if out of memory #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
reviewed
Mar 31, 2022
json_object.c
Outdated
| char *p = strdup(double_format); | ||
| if (p == NULL) | ||
| { | ||
| _json_c_set_last_err("json_c_set_set_serialization_double_format: " |
There was a problem hiding this comment.
typo: doubled _set_set_
(also below ... and also back in https://github.com/json-c/json-c/pull/755/files#diff-3dbecd622f44dd0c1d2cc6363ed0f5f5b13d0cc912f1d7580ebb2875dffab023R948 fwiw)
There was a problem hiding this comment.
Fixed, thank you! I have a talent to include typos in a message which I am about to copy...
If memory allocation fails in json_c_set_serialization_double_format or json_object_copy_serializer_data then return with an error value and preserve previous values without overriding them with NULL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If memory allocation fails in json_c_set_serialization_double_format or
json_object_copy_serializer_data then return with an error value and
preserve previous values without overriding them with NULL.
Shoutout to C3H2-CTF.