Don't try to change locale when libc only supports the C locale #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When uclibc is build only with C locale support we don't need to try and change to the C locale.
hawicz
reviewed
Jul 4, 2022
| @@ -298,11 +298,13 @@ struct json_object *json_tokener_parse_ex(struct json_tokener *tok, const char * | |||
| unsigned int nBytes = 0; | |||
| unsigned int *nBytesp = &nBytes; | |||
|
|
|||
| #ifndef __LOCALE_C_ONLY | |||
There was a problem hiding this comment.
Where does __LOCALE_C_ONLY get set? I would expect to see something in CMakeLists.txt
There was a problem hiding this comment.
Should get set by uclibc's locale.h header.
|
It turns out that even with locale support available, uClibc's duplocale() is crashes (see issue #705) so I ended up changing CMakeLists.txt to entirely disable locale handling there. With that in place, I believe this PR is unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uclibc is build only with C locale support we don't need to try and change to the C locale.