Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json_error_max → JSON_ERROR_MAX #124

Open
DimitriPapadopoulos opened this issue Aug 20, 2021 · 2 comments · May be fixed by #129
Open

json_error_max → JSON_ERROR_MAX #124

DimitriPapadopoulos opened this issue Aug 20, 2021 · 2 comments · May be fixed by #129
Assignees
Milestone

Comments

@DimitriPapadopoulos
Copy link
Contributor

DimitriPapadopoulos commented Aug 20, 2021

I would like to change json_error_max to uppercase, this is common C usage.

Is it considered to be part of the API? If not, it could be moved to json.c, otherwise we could keep both.

@DimitriPapadopoulos
Copy link
Contributor Author

Thinking about it, it has to be part of the API, for the end user to be able to provision a large enough error_buf.

@LB-- LB-- added this to the v1.2.0 milestone Aug 23, 2021
@LB--
Copy link
Member

LB-- commented Aug 23, 2021

Yes, I added it in 2013 in 09896ab for specifically that reason. I probably should have made it all caps, but back during 2013 there was no precedent for that in the codebase, and json_value_none was lowercase, so I matched that. It can certainly be changed to better clarify its constant nature.

@LB-- LB-- self-assigned this Aug 23, 2021
@DimitriPapadopoulos DimitriPapadopoulos linked a pull request Aug 23, 2021 that will close this issue
@LB-- LB-- modified the milestones: v1.2.0, v2.0.0 Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants