Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Integration #59

Open
vaclav2016 opened this issue Sep 3, 2016 · 1 comment
Open

CMake Integration #59

vaclav2016 opened this issue Sep 3, 2016 · 1 comment

Comments

@vaclav2016
Copy link

Hello!

I had modify build process into your parser/builder - I had add (looks like a) full cmake integration:
After sudo make install library will be available for cmake's operator find_package (cjson REQUIRED) - no need write extra cmake-Finder's

Also, I am had merge two libraries (builder+parser) into one, not sure is it interesting for you.

You can check it at:
https://github.com/vaclav2016/cjson

PS: Thanks! nice library !

@LB--
Copy link
Member

LB-- commented Aug 14, 2021

Hm, your CMake script looks considerably more complex than #67, and I am not entirely convinced about the value of having CMake support for this library anyway. It is nearly always preferable to just add the single source file and single header file into one's own existing build system, is it not? This library is intentionally trivial to build, so it seems a little excessive to add more different build systems to it, no?

@LB-- LB-- mentioned this issue Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants