Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make JsonPath non-private #954

Open
palatam opened this issue Aug 23, 2023 · 0 comments
Open

make JsonPath non-private #954

palatam opened this issue Aug 23, 2023 · 0 comments

Comments

@palatam
Copy link

palatam commented Aug 23, 2023

Currently the JsonPath class only has a single private Constructor and the field "path" is also private.

Making both elements protected allows users to extend/override the class and its behaviour.

Currently I need to build a local version so I can make JsonPath#read returns a map of absolutePath->value (currently it only returns only the values or the absolute paths of the hits and I would need to run the #read method twice with different configs).

If this idea will be rejected I will open a new one with a discussion about a proper implementation of a feature which returns map of hits containing absolutePath->value hoping that it will get approved (after the implementation details are clear I can make a PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant