Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unminified libs #11

Closed
dlodeprojuicer opened this issue Jun 26, 2014 · 5 comments
Closed

Unminified libs #11

dlodeprojuicer opened this issue Jun 26, 2014 · 5 comments

Comments

@dlodeprojuicer
Copy link
Contributor

Hi there. I tired using files in src folder but somehow they dont seem to be the same as the ones in dist. Is bootstrap-datepicker.min.js the same as bootstrap-datepicker.js in derectives/decorators/bootstrap/datepicker ?

I am trying to wrap my head around your recent update and I am trying to make sense of it all as I go. I am still new at this, please bare with me 😄

I was wondering if you could include unminified versions of the files in dist folder.

Thanks

@davidlgj
Copy link
Contributor

Sure, making uminified versions as well won't be a problem.

schema-form.min.js is actually everything in src/ except src/directives/decorators concatenated and minified.

bootstrap-decorator.min.js is everything directly in src/directives/decorators/bootstrap concatenated and minified. That includes all the html templates as well! They are compiled to js with gulp-angular-templatecache

bootstrap-datepicker.min.js, as you might have gathered by now, is is everything directly in src/directives/decorators/bootstrap/datepicker/, templates and all.

The idea was that scema-form.min.js should be the base you add "decorators" to, and that we in time could have several to choose from. I have a branch with a half done "table-decorator" that just renders everything in a table, useful to view values inputed.

And the datepicker I choose to add in a extra file since it has so many third party dependencies.

I'll try to add non minified versions shortly, but in the mean time you can build them yourself using gulp. Just comment out row 30 and 67 (.pipe(uglify())) in gulpfile.js. And then run "gulp".

If you don't have gulp, install node, do a "npm install" to install angular-schema-form dependencies, "npm install -g gulp" to get gulp and then just "gulp" to build :)

@dlodeprojuicer
Copy link
Contributor Author

I see, I was wondering where all the templates disappeared to. I will install gulp.

Maybe this could be a new issue:
You mentioned something about table-decorator, I was about to ask you about something of that sort.... I have started using ngGrid as a table, at the moment it is a side demo, I wanted to have something solid before doing a pull request. It is also half-done, I am struggling to put user inputs in the response.

Should I create a branch for it or uploading somewhere for you to run through it quick? It is not solid yet, so I am not sure....

@dlodeprojuicer
Copy link
Contributor Author

I managed to use the concatenated files, due to the structure of my demo, I prefer to work with separate files in src folder.

Thanks for helping me through this.

@davidlgj
Copy link
Contributor

No problem. Until recently the example/bootstrap-example.html just included all of the source files, the trick is to use a web server from the root of the project when viewing it so all the templates gets the correct path.

But I wanted the speed bump the concatenation gives you, doing 10 ajax requests to load small snippets of HTML isn't that great when you need them all at the same time :-)

Regarding your ng-grid demo, I'm not sure we're talking about the same thing but I love to see it when you feel comfortable, just clone the repo and put it in a branch!

@dlodeprojuicer
Copy link
Contributor Author

Will do!

@davidlgj davidlgj closed this as completed Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants