Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Cloudflare redirects from UI configuration to using _redirects file #161

Closed
Relequestual opened this issue Oct 18, 2023 · 8 comments · Fixed by #406
Closed

Migrate Cloudflare redirects from UI configuration to using _redirects file #161

Relequestual opened this issue Oct 18, 2023 · 8 comments · Fixed by #406
Assignees
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@Relequestual
Copy link
Member

Currently redirects are configured through the Cloudflare admin area for redirect rules.
Given we are using Cloudflare pages, we can specifiy redirects using a Cloudflare Pages function, a _redirects file.

Ideally, we should use a file in the repo over admin area configuration where possible.

Documentation: https://developers.cloudflare.com/pages/platform/redirects

@Relequestual Relequestual added the nice-to-have This is not an issue. This is something nice to have. label Oct 18, 2023
@benjagm benjagm added the ✨ Enhancement Indicates that the issue suggests an improvement or new feature. label Nov 22, 2023
@benjagm
Copy link
Collaborator

benjagm commented Nov 22, 2023

This is cool, thanks Ben. We'll work on this as soon as possible.

@benjagm benjagm added the Status: Available No one has claimed responsibility for resolving this issue. label Feb 20, 2024
@prajjwalyd
Copy link
Contributor

Hello! Can you please provide details about the existing redirects?

@benjagm
Copy link
Collaborator

benjagm commented Feb 23, 2024

Let me share them with you in a DM. Are you ok with working on this?

@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. labels Feb 23, 2024
@prajjwalyd
Copy link
Contributor

Yes Sure! I have sent you a DM on Slack.
My Display name is 'Prajjwal Yadav'.

@benjagm
Copy link
Collaborator

benjagm commented Feb 27, 2024

@prajjwalyd I just sent you a DM with the details of the redirects.

@benjagm
Copy link
Collaborator

benjagm commented Mar 5, 2024

We merged #406 but the redirect didn't worked Well need to review this behaviour.

@benjagm benjagm added 🐛 Bug Indicates that the issue is a bug or defect. and removed ✨ Enhancement Indicates that the issue suggests an improvement or new feature. nice-to-have This is not an issue. This is something nice to have. labels Mar 5, 2024
@benjagm benjagm assigned benjagm and unassigned prajjwalyd Mar 5, 2024
@prajjwalyd
Copy link
Contributor

@benjagm can you provide some more details on why it didn't work?

This was referenced Mar 6, 2024
@benjagm
Copy link
Collaborator

benjagm commented Mar 6, 2024

I't seemed a problem with the slack redirect only. Basically, in the recording I shared that redirect rule was not using URI Paths what made it confusing to translate to the plain _redirects file. I did some changes and tests and now it seems to work.

Huge thanks @prajjwalyd

@benjagm benjagm closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants