Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug: Too much top padding in Blogs landing page #427

Closed
benjagm opened this issue Mar 3, 2024 · 9 comments
Closed

馃悰 Bug: Too much top padding in Blogs landing page #427

benjagm opened this issue Mar 3, 2024 · 9 comments
Assignees
Labels
馃悰 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@benjagm
Copy link
Collaborator

benjagm commented Mar 3, 2024

Describe the bug

When accessing the Blogs landing page, there is too much vertical space between the the details of the last blog (label, title author) and the top menu:
Screenshot 2024-03-03 at 17 02 45

In mobile we are loosing most of the content:
Screenshot 2024-03-03 at 17 03 43

Steps To Reproduce

https://json-schema.org/blog

Expected Behavior

Less vertical padding in desktop version and a better approach for mobile.

Screenshots

No response

Device Information [optional]

- OS:
- Browser:
- version:

Are you working on this issue?

No

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No

@benjagm benjagm added 馃悰 Bug Indicates that the issue is a bug or defect. Status: Triage This is the initial status for an issue that requires triage. Status: Available No one has claimed responsibility for resolving this issue. and removed Status: Triage This is the initial status for an issue that requires triage. labels Mar 3, 2024
@TamannaVerma99
Copy link
Contributor

Hey @benjagm !
Just a small note, this issue might be redundant as Issue #412 . I have raised a PR concerning this issue (PR #420 ) which is yet to be reviewed. If there's any feedback on that issue, would resolve the same to cover this issue as well.
Thanks for your time!

@benjagm
Copy link
Collaborator Author

benjagm commented Mar 3, 2024

Can I assign both issue to you too? So we fix everything? #412 seems focused only in mobile.

@TamannaVerma99
Copy link
Contributor

Sure! I will do it. Thanks :)

@VivekJaiswal18
Copy link
Contributor

@benjagm So is this issue open. If yes then I am willing to take this issue! Thanks.

@satyam-x10
Copy link
Contributor

@benjagm I am interested in working on this. I have worked on UI with react and typescript .I would be grateful if i can work on this. Thank you

@Ekep-Obasi
Copy link

@benjagm I'd love to work on this issue

@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. labels Mar 3, 2024
@benjagm
Copy link
Collaborator Author

benjagm commented Mar 3, 2024

@TamannaVerma99 please go ahead considering that you are working in the same component.

@TamannaVerma99
Copy link
Contributor

Done with the required changes @benjagm .

@benjagm
Copy link
Collaborator Author

benjagm commented Mar 5, 2024

Closed as completed.

@benjagm benjagm closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 Bug Indicates that the issue is a bug or defect. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

No branches or pull requests

5 participants