Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out highlights that have been discarded in Readwise #17

Closed
jsonMartin opened this issue Dec 10, 2022 · 0 comments · Fixed by #18
Closed

Filter out highlights that have been discarded in Readwise #17

jsonMartin opened this issue Dec 10, 2022 · 0 comments · Fixed by #18
Labels
enhancement New feature or request
Projects
Readwise Mirror

Comments

@jsonMartin
Copy link
Owner

Readwise allows for discarding highlights (instead of hard deletion). Add Obsidian support for this feature.

If a highlight has been discarded, the is_discard field should be set to true.

Add a configuration toggle option in settings to filter discarded highlights. If this toggle setting is enabled, then filter out all highlights (inside filterHighlights method) where the is_discard field is set to true.
@jsonMartin jsonMartin added this to To do in Readwise Mirror via automation Dec 10, 2022
@jsonMartin jsonMartin added the enhancement New feature or request label Dec 10, 2022
@jsonMartin jsonMartin mentioned this issue Dec 11, 2022
Merged
Readwise Mirror automation moved this from To do to Done Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Readwise Mirror
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort Highlights By Location and Filter Discarded Highlights jsonMartin/readwise-mirror
1 participant
@jsonMartin