New copy to clipboard shortcut feature and footer icon

[DSGDSR]

Hi! I just created this PR adding a new shortcut for copying the selected node. I leave some images here... tried to follow svg structure you have in the project 😃

Few days using JSON Hero t handle big json files and feels quite comfortable... awesome app
Let me know how it looks, in case you want me to add/edit something let me know! Thanks

[ericallam]

Hi @DSGDSR, thanks for the contribution! I'll be taking a look at this in more detail on Friday. Glad you like JSON Hero and thanks for being our first outside PR 💯

[ericallam]

This is a great addition! Thanks for the PR. I do have a couple of things that I think will need to be done before this can be merged:

• Choose a different keyboard shortcut. It's a little dangerous overriding the default copy shortcut as it breaks copying anything else on the page when selecting some text and hitting CMD/CTRL+C
• Don't JSON.stringify strings to prevent the extraneous "" from being copied to the clipboard. You can do that by checking for selectedInfo?.name === "string"
• Ideally this would also work in the Tree View but currently it only works in the Column View. Not a dealbreaker for getting this PR merged as we could add support for the Tree View later without much problem.

[DSGDSR]

Thanks for reviewing my proposal! Totally agree with you mate, will work on it tomorrow 👍🏼 including the support for Tree View mode.

[DSGDSR]

Hi @ericallam, just updated the branch with the changes:

• Using shift+c now as shortcut, also thought about using cmd+u, but this would work for Windows too.
• Isolated component for this specific shortcut as it is used in the TreeView too, this way it was easily implemented instead of adding it to useVirtualTree hook as the rest of shortcuts.
• Checking the selected node name, in case it is an string the value would be copied to the clipboard without using JSON.stringify
• Modified the SVG accordingly:

[ericallam]

This attribute should be strokeWidth, not stroke-width

[DSGDSR]

Comment resolved 😺, thanks for the support and for accepting my proposal. Will be back if any feature comes to my mind while using jsonhero!

[ericallam]

This PR will be ready to merge once the above comment is resolved. Great work, such an awesome feature 👍