Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for resume ? #18

Closed
erwanlbp opened this issue Sep 14, 2020 · 2 comments
Closed

Translations for resume ? #18

erwanlbp opened this issue Sep 14, 2020 · 2 comments

Comments

@erwanlbp
Copy link

Hi,
Not sure if it's the right place to ask, but is there a plan to add the possibility to translate themes ? Maybe with some &lang=fr and adding translations in themes ...

@wuiler
Copy link

wuiler commented Nov 2, 2020

Same opinion. I DONT KNOW about node.js or express but maybe passing &lang=es or &lang=fr we coud change and add a gist
like fr.resume.json without adding any i18n package to complicate things.
Then we could verify if file exists too on Gists and added to firestore.

app.get("/:username", async (req, res) => {
    const username = req.params.username;


    let defaultResume = "resume.json";
    let resumeName = defaultResume;
    
    let lang = req.query.lang;
    if (!lang) {
        resumeName = lang + defaultResume;
    } 
 ...
 ...
 ...
    const resumeUrl = _.find(gistData.data, f => {
          return f.files[resumeName];
        });

@thomasdavis
Copy link
Member

Closing this in favor of jsonresume/resume-schema#35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants