Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to fields #250

Closed
oupala opened this issue Aug 23, 2016 · 4 comments
Closed

add link to fields #250

oupala opened this issue Aug 23, 2016 · 4 comments

Comments

@oupala
Copy link

oupala commented Aug 23, 2016

It would be great to be able to link some fields.

For example, nowadays, skills are set by the following

  "skills": [
    {
      "name": "tools",
      "level": "Master",
      "keywords": [
        "git",
        "wiki"
      ]
    }
  ]

I'd like to be able to set them as links:

  "skills": [
    {
      "name": "tools",
      "level": "Master",
      "keywords": [
        "[git](http://fr.wikipedia.org/wiki/Git)",
        "[wiki](http://fr.wikipedia.org/wiki/Wiki)"
      ]
    }
  ]

or in a separate field:

  "skills": [
    {
      "name": "tools",
      "level": "Master",
      "keywords": [
        {
           "name": "git",
           "url": "http://fr.wikipedia.org/wiki/Git"
        },
        {
           "name": "wiki",
           "url": "http://fr.wikipedia.org/wiki/Wiki"
        }
      ]
    }
  ]

This has been discussed here: mudassir0909/jsonresume-theme-elegant#81

@stp-ip
Copy link
Member

stp-ip commented Aug 23, 2016

Thanks for proposing, we had a similar idea with making it possible to substitute plaintext fields with markdown.

@KOLANICH
Copy link

KOLANICH commented Sep 25, 2016

I don't think it is a nice idea to support links and other markdown in category fields like tags. The behavior should be implementation defined. Tags have semantics being tags, machine readable semantic meaningful identifiers which are not needed to be cleaned from crap. Tags are not links to external resources, and every resource decides itself what click on tags should do. In most cases it triggers search, in some cases it shows word definition. Tags is just the way to say to the website "this document is about %tagname%, please, use this information".

@James-Firth
Copy link

I like the second idea of having the url as a separate key, otherwise you force all readers/renderers to understand the markdown syntax as well.

@stp-ip
Copy link
Member

stp-ip commented Dec 24, 2016

So the current state or plan is to either provide a url field, if deemed necessary within the schema or use the proposed meta.enhancedText section, which might overwrite fields with a markdown based variant.

Gonna close this as it can be tracked within the #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants