Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship with shapesecurity/unminify #1

Open
re-engineer opened this issue Aug 5, 2020 · 1 comment
Open

Relationship with shapesecurity/unminify #1

re-engineer opened this issue Aug 5, 2020 · 1 comment

Comments

@re-engineer
Copy link

Hello,
I was wondering what the end-goal for these plugins is meant to be, especially given the other set of util functions for refactoring Shift ASTs in shapesecurity/unminify. Is this library and its plugins meant to replace the functionality of unminify, or just to act as a tool for more fine control of AST manipulation? Do you plan to expose certain transforms from unminify in this, as they are basically equivalent to common util methods?

Apologies for the long message; I just appreciate shift-refactor and am curious about its future and how it will affect the structure of my programs using it.

@jsoverson
Copy link
Owner

Unminify came first and proved out some concepts. Shift-refactor is a personal project that started with unminify as a dependency but grew to sit on its own to experiment with a different API for generic AST transformation.

I moved out the "common" and "unsafe" methods once refactor became more generic and I need to revisit them. Uniminify's transformations are probably much safer and more correct so I will use them as a guide for mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants