Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple logging of API requests per experiment #66

Closed
jodeleeuw opened this issue Jan 3, 2023 · 2 comments · Fixed by #68
Closed

add simple logging of API requests per experiment #66

jodeleeuw opened this issue Jan 3, 2023 · 2 comments · Fixed by #68

Comments

@jodeleeuw
Copy link
Member

Log number of requests per experiment for each API endpoint for some basic health monitoring. This should help us detect where a problem is if there is a sudden surge in spam, for example.

@vsoch
Copy link

vsoch commented Jan 3, 2023

From experience (and sorry piping in - I've been mostly a fly on the wall) you will hugely benefit from rate limiting. E.g., it's good to monitor requests but better if you can set, for an example, an hourly / daily limit based on ip address or another identifier.

@jodeleeuw jodeleeuw linked a pull request Jan 3, 2023 that will close this issue
@jodeleeuw
Copy link
Member Author

thanks, @vsoch. I'll think about how to do this. The trick is that API calls are unauthenticated, so I guess it would have to be by IP... will open a different issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants