You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found that jspsych-instructions plugin not allowed to change the word "page" before the x/y in show_page_number. This is a problem if you want to made an experiment in non english language. So I added a parameter ' page_label ' in plugin.info where everyone can change the text before x/y.
Also changed the documentation in two parts:
New Parameter 'page_label'.
The existing parameter 'show_page_number' does not appear in the documentation, so I added it.
#1081 (comment)
(sorry if I am adding commits from other pull request, i'm pretty new using pull requests)
The text was updated successfully, but these errors were encountered:
It does look like you also added two files to your pull request relating to the virtual chin rest plugin. You could try reverting the commits that added or made changes to those files - see this stack overflow comment. Or we can merge your pull request and then remove those files ourselves. @jodeleeuw let me know if you have a preference or other suggestions.
It also looks like you removed this Parameters heading and line of text from the instructions plugin markdown doc:
Parameters
Parameters with a default value of undefined must be specified. Other parameters can be left unspecified if the default value is acceptable.
So I'll add that back in, unless there was a reason for removing it?
It does look like you also added two files to your pull request relating to the virtual chin rest plugin. You could try reverting the commits that added or made changes to those files - see this stack overflow comment. Or we can merge your pull request and then remove those files ourselves. @jodeleeuw let me know if you have a preference or other suggestions.
Sorry! I'm pretty new at this. I think I tried to revert the commits, but maybe I did it wrong: 49f68b7
It also looks like you removed this Parameters heading and line of text from the instructions plugin markdown doc:
Parameters
Parameters with a default value of undefined must be specified. Other parameters can be left unspecified if the default value is acceptable.
So I'll add that back in, unless there was a reason for removing it?
Oops, there is not a reason for that. Feel free to add it again.
Ah you're right, it looks like you did revert those commits already. Thanks!
No problem about the unintentional changes to the docs - I'll just add those lines back in. And I noticed that you hadn't added yourself to the contributors file, so I'll do that too 😃
Thanks again!!
I found that jspsych-instructions plugin not allowed to change the word "page" before the x/y in show_page_number. This is a problem if you want to made an experiment in non english language. So I added a parameter ' page_label ' in plugin.info where everyone can change the text before x/y.
Also changed the documentation in two parts:
#1081 (comment)
(sorry if I am adding commits from other pull request, i'm pretty new using pull requests)
The text was updated successfully, but these errors were encountered: