Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instructions plugin can't display 'Page' in another language / show_page_number' does not appear in the documentation #1082

Closed
GEJ1 opened this issue Sep 27, 2020 · 4 comments

Comments

@GEJ1
Copy link
Contributor

GEJ1 commented Sep 27, 2020

I found that jspsych-instructions plugin not allowed to change the word "page" before the x/y in show_page_number. This is a problem if you want to made an experiment in non english language. So I added a parameter ' page_label ' in plugin.info where everyone can change the text before x/y.

Also changed the documentation in two parts:

  1. New Parameter 'page_label'.
  2. The existing parameter 'show_page_number' does not appear in the documentation, so I added it.

#1081 (comment)
(sorry if I am adding commits from other pull request, i'm pretty new using pull requests)

@becky-gilbert
Copy link
Collaborator

Thanks very much for this contribution @GEJ1!

It does look like you also added two files to your pull request relating to the virtual chin rest plugin. You could try reverting the commits that added or made changes to those files - see this stack overflow comment. Or we can merge your pull request and then remove those files ourselves. @jodeleeuw let me know if you have a preference or other suggestions.

It also looks like you removed this Parameters heading and line of text from the instructions plugin markdown doc:

Parameters

Parameters with a default value of undefined must be specified. Other parameters can be left unspecified if the default value is acceptable.

So I'll add that back in, unless there was a reason for removing it?

@GEJ1
Copy link
Contributor Author

GEJ1 commented Oct 1, 2020

It does look like you also added two files to your pull request relating to the virtual chin rest plugin. You could try reverting the commits that added or made changes to those files - see this stack overflow comment. Or we can merge your pull request and then remove those files ourselves. @jodeleeuw let me know if you have a preference or other suggestions.

Sorry! I'm pretty new at this. I think I tried to revert the commits, but maybe I did it wrong: 49f68b7

It also looks like you removed this Parameters heading and line of text from the instructions plugin markdown doc:

Parameters

Parameters with a default value of undefined must be specified. Other parameters can be left unspecified if the default value is acceptable.

So I'll add that back in, unless there was a reason for removing it?

Oops, there is not a reason for that. Feel free to add it again.

@becky-gilbert
Copy link
Collaborator

Ah you're right, it looks like you did revert those commits already. Thanks!
No problem about the unintentional changes to the docs - I'll just add those lines back in. And I noticed that you hadn't added yourself to the contributors file, so I'll do that too 😃
Thanks again!!

@becky-gilbert
Copy link
Collaborator

becky-gilbert commented Oct 2, 2020

  • move instructions plugin docs changes to docs-6.2 branch and revert on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants