Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CacheWriterTest.shouldWriteThroughUsingInvoke_setValue_CreateEntryThenRemove asserts writer delete not called #84

Closed
cruftex opened this issue Oct 4, 2015 · 3 comments
Assignees

Comments

@cruftex
Copy link
Member

cruftex commented Oct 4, 2015

The test sets and removes a value via the EntryProcessor, that is not yet existing in the cache and asserts:

    assertEquals(0, cacheWriter.getWriteCount());
    assertEquals(0, cacheWriter.getDeleteCount());

The Spec says that a Cache.remove() should always call writer.delete() if write trough is enabled, and the MutableEntry.remove() should behave identical. However, in this case the TCK asserts that the remove had no effect.

Probably the TCK interprets that the "net effect" of the operation is none, but that is only correct regarding the cache state.

@cruftex
Copy link
Member Author

cruftex commented Mar 10, 2016

Probably it is better to change and clarify the Spec and not change all existing implementations. Reviewed the EntryProcessor JavaDoc carefully and opened an issue against the Spec.

@gregrluck
Copy link
Member

Looks like Jens is correct on this. How does Coherence work on this point?

@gregrluck gregrluck added this to the 1.1.0 milestone May 14, 2016
@cruftex
Copy link
Member Author

cruftex commented May 14, 2016

Decided to updated the Spec and close this.

@cruftex cruftex closed this as completed May 14, 2016
@gregrluck gregrluck removed this from the 1.1.0 milestone May 14, 2016
@gregrluck gregrluck removed the Defect label May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants