Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict convention for _id, shortid, name attributes #732

Closed
pofider opened this issue Jul 1, 2020 · 2 comments
Closed

Strict convention for _id, shortid, name attributes #732

pofider opened this issue Jul 1, 2020 · 2 comments
Labels

Comments

@pofider
Copy link
Contributor

pofider commented Jul 1, 2020

Currently, we use several attributes like publicKey, key, humanReadableKey on the entity properties. We should remove these and be strict with the name convention, that every entity has _id, shortid, name, (modificationDate) attributes.

@pofider pofider added the v3 label Jul 1, 2020
@pofider
Copy link
Contributor Author

pofider commented Nov 4, 2020

I believe only the user has "username" instead of the "name". So I would rename it there. Every other entity should have _id, shortid, name, modificationDate and we can remove all the logic with humanReadableKey....

@pofider
Copy link
Contributor Author

pofider commented Apr 1, 2021

Ready for v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant