Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsreport cli start: detect jsreport using normal node resolution #988

Open
bjrmatos opened this issue Oct 27, 2022 · 0 comments
Open

jsreport cli start: detect jsreport using normal node resolution #988

bjrmatos opened this issue Oct 27, 2022 · 0 comments

Comments

@bjrmatos
Copy link
Collaborator

our code to detect the installed jsreport dependency works great in normal apps, but when using it inside a monorepo (like npm workspaces) it fails. this is because we just search the jsreport dep in the current cwd, but in a monorepo the deps are installed in different location, we currently have some fallback code that uses normal node.js resolution but i don't remember why we do it just at a specific case, perhaps we just did it to prevent such fallback going to the wider audience because it was not common to have the node_modules somewhere at a higher level (monorepos were not popular before).

we should probably review this and update a bit the logic.

context: https://forum.jsreport.net/topic/2601/error-when-run-jsreport-start/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant