Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL detection breaks some Apache Camel thread dumps #10

Closed
maisi opened this issue Apr 6, 2021 · 1 comment
Closed

URL detection breaks some Apache Camel thread dumps #10

maisi opened this issue Apr 6, 2021 · 1 comment

Comments

@maisi
Copy link

maisi commented Apr 6, 2021

Hello,

while using your tool I've encountered an issue that some Apache Camel thread dumps won’t be analyzed because they include an URL in their name.

Example:

"Camel (camel) thread #2 - eft://http://saas-eft:8008/bshatlas" #95 daemon prio=5 os_prio=0 tid=0x00007fef7fb60800 nid=0x41ba runnable [0x00007fef310e9000]
   java.lang.Thread.State: RUNNABLE
	at sun.nio.ch.FileDispatcherImpl.read0(Native Method)
	at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:39)
	at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
	at sun.nio.ch.IOUtil.read(IOUtil.java:197)
	at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:377)
	- locked <0x00000000851def98> (a java.lang.Object)
	at oracle.net.nt.TimeoutSocketChannel.read(TimeoutSocketChannel.java:178)
	at oracle.net.ns.NSProtocolNIO.doSocketRead(NSProtocolNIO.java:544)
	at oracle.net.ns.NIOPacket.readHeader(NIOPacket.java:234)
	at oracle.net.ns.NIOPacket.readPacketFromSocketChannel(NIOPacket.java:174)
	at oracle.net.ns.NIOPacket.readFromSocketChannel(NIOPacket.java:122)
	at oracle.net.ns.NIOPacket.readFromSocketChannel(NIOPacket.java:100)
[...]

I've created a fork and commented out the lines responsible for URL detection, after which the thread dumps will be analyzed as expected. (maisi@a9f99fa)
However this essentially breaks the import-from-URL feature, which is why I haven't submitted a pull request.

Thanks for your tool, really helps with my daily work :)

BR
Martin

@elmuerte
Copy link
Member

elmuerte commented Apr 7, 2021

Should be fixed now. I made the URL checking on the input more strict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants