Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Published service undiscoverable due to NSEC #1088

Closed
bbusse opened this issue Aug 10, 2022 · 1 comment · Fixed by #1326
Closed

Published service undiscoverable due to NSEC #1088

bbusse opened this issue Aug 10, 2022 · 1 comment · Fixed by #1326
Labels
needs-more-information

Comments

@bbusse
Copy link

bbusse commented Aug 10, 2022

There is a problem when trying to discover a service published by python-zeroconf with https://github.com/grandcat/zeroconf/ See also: grandcat/zeroconf#34 Leaving out the NSEC block in python-zeroconf, e.g. not sending it at all, makes the discovery work with the golang side
@bdraco
Copy link
Member

bdraco commented Sep 5, 2022

Looks like a bug in https://github.com/jstasiak/python-zeroconf/blob/60167b05227ec33668aac5b960a8bc5ba5b833de/zeroconf/_dns.py#L474

Unfortunately, I don't see the problem, but happy to take a patch if you can work out whats wrong.

bbusse added a commit to bbusse/python-zeroconf that referenced this issue Oct 16, 2022
@bbusse
workaround python-zeroconf#1088: Do not send NSEC package
ab4070a
@bdraco bdraco mentioned this issue Dec 10, 2023
Closed
bdraco added a commit that referenced this issue Dec 10, 2023
@bdraco
fix: ensure invalid nsec records cannot be written
d7ce2f4 
fixes #1320
fixes #1088
@bdraco bdraco mentioned this issue Dec 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-more-information
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correct nsec record writing python-zeroconf/python-zeroconf
2 participants
@bdraco @bbusse