New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip network adapters that are disconnected #327
Conversation
Don't fail to initialise if a network adapter is disconnected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Two small comments, looks good otherwise.
And actually use the interface formatting parameter
@ZLJasonG would you please rebase this PR to the latest master? |
fixes #326 |
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
- Coverage 98.72% 98.68% -0.04%
==========================================
Files 22 22
Lines 2271 2279 +8
Branches 389 389
==========================================
+ Hits 2242 2249 +7
Misses 18 18
- Partials 11 12 +1
Continue to review full report at Codecov.
|
1c868c1
to
18e32c1
Compare
Looks like https://github.com/python/cpython/blob/main/Modules/errnomodule.c#L253 |
Don't fail to initialise if a network adapter is disconnected.
fixes #326