Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS Binaries need to be notarized #30

Closed
MylesBorins opened this issue Aug 26, 2020 · 7 comments
Closed

MacOS Binaries need to be notarized #30

MylesBorins opened this issue Aug 26, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@MylesBorins
Copy link
Member

I can't wrap my head around why, but when testing the MacOS built binaries on my local machine it take many seconds to start. This is not the case with a locally built binary using the exact same commands. I'm confused

@devsnek
Copy link
Member

devsnek commented Aug 28, 2020

Does it happen on any other platform? MacOS pings apple's servers when an unknown binary is exec()'d and that can take a few seconds.

@MylesBorins
Copy link
Member Author

@devsnek that sounds like it could be a reasonable explanation. Do we need to notarize the binaries to avoid this?

@devsnek
Copy link
Member

devsnek commented Aug 29, 2020

I don't really know that much about it. If you have a Linux x64 build I can test it to see if it's also slow.

@MylesBorins MylesBorins added the bug Something isn't working label Aug 29, 2020
@solumos
Copy link
Contributor

solumos commented Aug 31, 2020

The Windows binary appears to be OK, in case anyone was wondering

@MylesBorins MylesBorins changed the title Binaries built with CI / CD are very slow MacOS Binaries built with CI / CD are very slow Aug 31, 2020
@MylesBorins
Copy link
Member Author

I just confirmed that the node.js binary is similarly slow on 10.15.6... so this is definitely a notarization thing 😭

Looks like we need a developer account in order to get notarization working. Almost feels like it would be easier to get jstime into homebrew for binary distribution than to work out how to get notarization working in CD.

@MylesBorins MylesBorins changed the title MacOS Binaries built with CI / CD are very slow MacOS Binaries need to be notarized Aug 31, 2020
@MylesBorins MylesBorins added enhancement New feature or request and removed bug Something isn't working labels Aug 31, 2020
@MylesBorins
Copy link
Member Author

@MylesBorins
Copy link
Member Author

I did some more research + testing... simply moving the binary out of the downloads folder is enough to stop the slow down. Even weirder, moving it out of the download folder and back also stops the slow down. WAT.

The node.js binary is also affected by this, and has the same solution when moved from download folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants