Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore case for filter methods #372

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ARandomPerson07
Copy link

Description

Added the ability to ignore case sensitivity when filtering PDF elements by text matching. Default is not to ignore (i.e. doesn't break logic with previous versions).

Linked issues

closes #371

Testing

Created a simple PDF with various uppercase-lowercase combinations. Compared length of filtered output when the associated filter_by_text_equal and filter_by_text_contains functions are run with ignore_case as both True and False. Behaves as expected.

Testing text:
image

Results:
image

Checklist

  • I have provided a good description of the change above
  • I have added any necessary tests
  • I have added all necessary type hints
  • I have checked my linting (docker-compose run --rm lint)
  • I have added/updated all necessary documentation
  • I have updated CHANGELOG.md, following the format from
    Keep a Changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter text ignoring case
1 participant