Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the ability to ignore case sensitivity when filtering PDF elements by text matching. Default is not to ignore (i.e. doesn't break logic with previous versions).
Linked issues
closes #371
Testing
Created a simple PDF with various uppercase-lowercase combinations. Compared length of filtered output when the associated
filter_by_text_equal
andfilter_by_text_contains
functions are run withignore_case
as bothTrue
andFalse
. Behaves as expected.Testing text:
![image](https://private-user-images.githubusercontent.com/90392744/241160579-d3470d13-00bd-46ae-b7ed-53c5a088e90e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkwODIwNDksIm5iZiI6MTcxOTA4MTc0OSwicGF0aCI6Ii85MDM5Mjc0NC8yNDExNjA1NzktZDM0NzBkMTMtMDBiZC00NmFlLWI3ZWQtNTNjNWEwODhlOTBlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIyVDE4NDIyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUyMjEyZGMyMmU1NTA2Njg5ODVjNWNlNzk3M2U4YjU2OTQ4OTkyMTRiZjdmYWQxNGY4YTFmMzFkOTM1MjQzYTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.5k8Q2IUi7s-51uM7XocByyNPfWvW6tYgsHYdx2HBvtw)
Results:
![image](https://private-user-images.githubusercontent.com/90392744/241161255-b0a4976c-9dda-49ae-ba06-3b8444c0e208.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkwODIwNDksIm5iZiI6MTcxOTA4MTc0OSwicGF0aCI6Ii85MDM5Mjc0NC8yNDExNjEyNTUtYjBhNDk3NmMtOWRkYS00OWFlLWJhMDYtM2I4NDQ0YzBlMjA4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIyVDE4NDIyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA0MTUyZjAwNjk3Y2QxZDEyNWJlNmY2ZmI0MTY4MWExZDM2NzAzNDg4ZWQwMDUxNzRkZTk0N2FlMmU0NjlmZDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.8dL62VGc5MkVRokQEsBmT8SKH4Q3MSKE8uRsT24AXCc)
Checklist
docker-compose run --rm lint
)CHANGELOG.md
, following the format fromKeep a Changelog.