Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong class name on context menu? #38

Closed
jimmywarting opened this issue Jun 26, 2020 · 3 comments
Closed

Wrong class name on context menu? #38

jimmywarting opened this issue Jun 26, 2020 · 3 comments

Comments

@jimmywarting
Copy link

I tried the disabled option and tried to make it look disabled, but it still had the same color as the rest.

https://github.com/paulhodel/jsuites/blob/e5445d63065f3c8f5422dd0b57a147d11fd1eed1/dist/jsuites.js#L2169-L2171

Looking at your well written source code (since the documentation is so bad) I found out that you add the class jcontextmenu-disabled to disabled items, but there is no css selector that match that name.

https://github.com/paulhodel/jsuites/blob/e5445d63065f3c8f5422dd0b57a147d11fd1eed1/dist/jsuites.css#L1487-L1489

@jimmywarting
Copy link
Author

jimmywarting commented Jun 26, 2020

I'm only guessing but i think it should be

.jcontextmenu .jcontextmenu-disabled a {
  color: #a1a192;
}

only using .jcontextmenu .jcontextmenu-disabled don't work since it gets overridden by a tripple match .jcontextmenu > div a

@jimmywarting
Copy link
Author

jimmywarting commented Jun 26, 2020

fyi, i think you should change this also:

- .jcontextmenu > div:not(.contextmenu-line):hover {
+ .jcontextmenu > div:not(.contextmenu-line, .jcontextmenu-disabled):hover {
    background: #ebebeb;
}

@pphod
Copy link
Contributor

pphod commented Jun 26, 2020

I have fixed that.

@pphod pphod closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants