Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date to string conversion #39

Closed
paulbriton opened this issue Jun 26, 2020 · 4 comments · Fixed by #41
Closed

Date to string conversion #39

paulbriton opened this issue Jun 26, 2020 · 4 comments · Fixed by #41

Comments

@paulbriton
Copy link

I've tracked down this related issue in jExcel and I figured out that it could be solved quite easily in jsuites.js:

// Helper to convert date into string
jSuites.calendar.getDateString = function(value, format) {
    ...
    if (value) {
        var d = ''+value;
        // instead of:
        // d = d.split(' ');
        var splitStr = (d.indexOf('T') !== -1) ? 'T' : ' ';
        d = d.split(splitStr);
       ...

I'll be glad to do a PR but I'm also facing a mixed line endings problem like in #34.

@pphod
Copy link
Contributor

pphod commented Jun 26, 2020

I have unified, hopefully it is working now. Let me know if you have same problems.

@pphod pphod closed this as completed Jun 26, 2020
@paulbriton
Copy link
Author

Still having issue with line endings. You can check this comparison with a fork.

@pphod
Copy link
Contributor

pphod commented Jun 27, 2020

I have change one other thing, it seems better now.

@paulbriton
Copy link
Author

@paulhodel When do you plan to make a new release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants