aria-invalid={true/false} incorrectly fails check

[fracmak]

When specifying aria-invalid="false" or aria-invalid="true", the value gets converted into a boolean by getLiteralPropValue(), which fails the token check because it's looking for a "string".

[ljharb]

aria-invalid={true} is not a valid value - that will end up as aria-invalid="aria-invalid", which is not a correct spec value. You must provide the literal string - not boolean - "true" or "false".

If I'm misunderstanding your issue, please provide some code so I can unconfuse myself :-)

[fracmak]

That's what I did and it still failed. aria-invalid="true" as far as I can tell the getLiteralPropValue() function is recognizing the "true" as a Boolean and casting it out of the string. No way I can find around it.

[ljharb]

aha, thanks for clarifying.

[beefancohen]

ah good find, thanks! basically, the ARIA properties needs to be able to handle multiple types. In this case, aria-invalid can be either a token or a boolean. would you be interested in trying to fix this bug? i'd be happy to help you along the way!

[fracmak]

Sure, what did you have in mind to fix this? One option I had considered was removing the constraint that all token values had to be string, and instead matching that the token value merely === the value stored in ARIA.json, I'd then update ARIA-INVALID's value's to be [ "grammar", "false", "spelling", "true", false, true ]

[beefancohen]

@fracmak great, thanks! always nice getting more people involved.

that seems like a good fix, although i don't think the string values "true" and "false" will ever be hit. [ "grammar", "spelling", true, false ] should be sufficient.

the equality check is here

[fracmak]

Fixed in #126

[beefancohen]

published in v3.0.2! thanks for reporting and your help fixing!