Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form onSubmit trips jsx-a11y/no-noninteractive-element-interactions rule #323

Closed
roubaobaozi opened this issue Sep 12, 2017 · 3 comments · Fixed by #871
Closed

form onSubmit trips jsx-a11y/no-noninteractive-element-interactions rule #323

roubaobaozi opened this issue Sep 12, 2017 · 3 comments · Fixed by #871

Comments

@roubaobaozi
Copy link

roubaobaozi commented Sep 12, 2017

eg.

<form onSubmit={this.handleSubmit.bind(this)} method="POST">
    <button type="submit">
        Save
    </button>
</form>

This rule makes sense for a div or span etc., but not in the above case.

@ljharb
Copy link
Member

ljharb commented Sep 12, 2017

Indeed, forms should be able to have onSubmit (the issue that .bind in the render path is super slow would be handled by eslint-plugin-react :-) )

@Einere
Copy link

Einere commented Jun 29, 2022

when this issue will resolve?

@ljharb
Copy link
Member

ljharb commented Jun 29, 2022

@Einere when someone submits a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants