Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-errormessage: This attribute is an invalid ARIA attribute jsx-a11y/aria-props #424

Closed
yaosha opened this issue May 8, 2018 · 5 comments
Assignees

Comments

@yaosha
Copy link

yaosha commented May 8, 2018

Is it wrong that I use it incorrectly?

@evocateur
Copy link
Contributor

I’m sorry, what do I have to do with this issue? You don’t generally need to ping the owner of the repo in your issue, trust me, they will get the notification.

If you want any response at all, I would suggest providing more actionable details. Were I the maintainer, in its present state, I would close this issue immediately.

@ljharb
Copy link
Member

ljharb commented May 8, 2018

@yaosha can you provide the code that’s erroring, and the error message?

@yaosha
Copy link
Author

yaosha commented May 8, 2018

sorry, this is my code.

render() {
    return (
      <input type="text" 
                   value={value} 
                   role={'spinbutton'}
                   aria-valuenow={value}
                   aria-valuemin={min}
                   aria-valuemax={max}
                   aria-label={label}
                   aria-required={required}
                   aria-disabled={disabled}
                   aria-errormessage={tipId}
                   aria-invalid={hasError}/>
    );
  }

package.json

"dependencies": {
    "echarts": "^3.6.1",
    "lodash": "^4.17.4",
    "prop-types": "^15.0.0",
    "react": "^15.6.2",
    "react-a11y": "^1.0.0",
    "react-dom": "^15.6.2",
    "react-intl": "^2.3.0"
  },
"devDependencies": {
    "babel-core": "^6.17.0",
    "babel-eslint": "^7.2.2",
    "babel-loader": "^7.1.2",
    "babel-plugin-istanbul": "^3.0.0",
    "babel-plugin-transform-runtime": "^6.23.0",
    "babel-preset-env": "^1.6.1",
    "babel-preset-react": "^6.24.1",
    "babel-preset-stage-0": "^6.24.1",
    "babel-preset-stage-1": "^6.24.1",
    "babel-runtime": "^6.26.0",
    "eslint": "^3.13.0",
    "eslint-plugin-import": "^2.2.0",
    "eslint-plugin-jsx-a11y": "^6.0.3",
    "eslint-plugin-react": "^6.9.0"
  }

.eslintrc

{
  "parser": "babel-eslint",
  "rules": {
  },
  "plugins": [
    "jsx-a11y"
  ],
  "extends": [
    "plugin:jsx-a11y/recommended"
  ]
}

and the lint result

371:20  error  aria-errormessage: This attribute is an invalid ARIA attribute                                                      jsx-a11y/aria-props

@jessebeach
Copy link
Collaborator

textbox inherits input inherits widget which includes aria-errormessage in aria-query: https://github.com/A11yance/aria-query/blob/master/scripts/roles.json#L3435

The input tag maps to the TextFieldRole in axobject-query. So on the surface, it appears that the attribute is represented and that this should pass, which leads me to believe that this is a version issue.

{ name: 'input' } => Set { 'InlineTextBoxRole', 'TextFieldRole' },

And yet it is failing on master: #426

This warrants some investigation.

@jessebeach
Copy link
Collaborator

Fixed in #425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants