Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule proposal: prop quotes #12

Closed
lencioni opened this issue Mar 7, 2015 · 2 comments
Closed

Rule proposal: prop quotes #12

lencioni opened this issue Mar 7, 2015 · 2 comments
Labels
accepted enhancement rule

Comments

@lencioni
Copy link
Collaborator

lencioni commented Mar 7, 2015

Similar to ESLint's built-in quotes rule, it would be nice to have a rule that enforces the style of quotes used for props. For instance, if set to "double":

Good:

<MyComponent myProp="value" />

Bad:

<MyComponent myProp='value' />
@xjamundx xjamundx mentioned this issue Mar 13, 2015
Closed
@lo1tuma
Copy link

lo1tuma commented Mar 13, 2015

As mentioned in eslint/eslint#2011, the suggested rule has nothing to do with react. It is a rule specific to the jsx syntax.

@oliviertassinari
Copy link
Contributor

Shouldn't we remove this rule? eslint/eslint@3988b47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted enhancement rule
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yannickcr @lo1tuma @lencioni @oliviertassinari