Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsx-sort-props callbacksLast missing fixer function #1991

Closed
jakub-chatrny opened this issue Sep 19, 2018 · 2 comments
Closed

jsx-sort-props callbacksLast missing fixer function #1991

jakub-chatrny opened this issue Sep 19, 2018 · 2 comments

Comments

@jakub-chatrny
Copy link

jsx-sort-props is marked as fixable but option callbacksLast seems to lack fix function here

@jakub-chatrny
Copy link
Author

I've found comment in code explaining this is not possible due to potencional prop override
// Sort props according to the context. Only supports ignoreCase. // Since we cannot safely move JSXSpreadAttribute (due to potential variable overrides), // we only consider groups of sortable attributes.

@ljharb
Copy link
Member

ljharb commented Sep 19, 2018

Indeed, not all things are autofixable.

PRs to improve autofixability are always great, but ordering rules are never fully autofixable.

@ljharb ljharb closed this as completed Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants