New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new rule for getDerivedStateFromProps #1999

Closed

dotterian opened this issue Sep 26, 2018 · 1 comment · Fixed by #2006

Labels

enhancement help wanted

dotterian commented Sep 26, 2018

React enforces getDerivedStateFromProps to be static method.
When I use it as instance method i get this error in browser

It would be great if eslint could check for this error and warn me in case I forget to place "static" before my "getDerivedStateFromProps".

I'd write this rule myself but I don't have enough free time and lack knowledge of how to write eslint rules properly.

Member

ljharb commented Sep 26, 2018

That seems reasonable (although your tests should have caught that too). Seems like something no-typos could handle?

ljharb added enhancement help wanted labels

bsonntag mentioned this issue

Update no-typos rule to check static lifecycle methods #2006

Merged

ljharb closed this as completed in #2006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment