Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be better to use defaultProps instead of defaultProp in warning? #2063

Closed
billychan opened this issue Nov 30, 2018 · 1 comment
Closed

Comments

@billychan
Copy link

billychan commented Nov 30, 2018

The warning message for defaultProps are:

 'propType "{{name}}" is required and should not have a defaultProp declaration.',
 'propType "{{name}}" is not required, but has no corresponding defaultProp declaration.',

A bit confusing when reading, since defaultProps is the valid method name. Maybe better to replace that?

Thanks

@ljharb
Copy link
Member

ljharb commented Nov 30, 2018

Sure, i can see how that’d be confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants