Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react/prop-types does not validate missing propTypes for functions in version 7.17.0 #2526

Closed
johnarnfield opened this issue Dec 16, 2019 · 0 comments · Fixed by #2533
Closed

Comments

@johnarnfield
Copy link

johnarnfield commented Dec 16, 2019

Seems like this is still an issue in version 7.17.0

Missing prop types do not raise errors in a function component with a return of:

return (
    ordering.length > 0 && (
      <Paginator items={ordering} pageSize={10} />
    )
)

But do with a function component with a return of:

  if (ordering.length > 0) {
    return false;
  }

  return (
    <Paginator items={ordering} pageSize={10} />
  )

and:

  return ordering.length > 0 ? (
    <Paginator items={ordering} pageSize={10} />
  ) : null;

Originally posted by @johnarnfield in #2134 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants