Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react/jsx-key doesn't detect Array.from #3368

Closed
Janpot opened this issue Aug 23, 2022 · 0 comments · Fixed by #3369
Closed

react/jsx-key doesn't detect Array.from #3368

Janpot opened this issue Aug 23, 2022 · 0 comments · Fixed by #3369
Labels
enhancement help wanted

Comments

@Janpot
Copy link

Janpot commented Aug 23, 2022 •
edited
Loading

react/jsx-key doesn't detect a specific case where an iterable is mapped using Array.from:

const mySet = new Set()

// ...

// Should warn for missing key property, but doesn't
Array.from(mySet, () => <div />)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] jsx-key not detecting missing keys in Array.from's mapping function sjarva/eslint-plugin-react
2 participants
@ljharb @Janpot