Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsx-curly-brace-presence] template literals contains just expressions #3537

Closed
taozhou-glean opened this issue Feb 24, 2023 · 1 comment · Fixed by #3538
Closed

[jsx-curly-brace-presence] template literals contains just expressions #3537

taozhou-glean opened this issue Feb 24, 2023 · 1 comment · Fixed by #3538

Comments

@taozhou-glean
Copy link
Contributor

we enabled jsx-curly-brace-presence, but I am seeing patterns in some code like following:

<Comp label={`${componentLabel}`} />

// or

<Comp>
{`${someText}`}
</Comp>

which would be same as:

<Comp label={componentLabel} />

// or

<Comp>
{someText}
</Comp>

and this seems to be an ideal case to be caught by jsx-curly-brace-presence ;)

=> Found "eslint-plugin-react@7.32.2"
=> Found "eslint@8.34.0"

@ljharb
Copy link
Member

ljharb commented Jul 21, 2023

I wasn't paying enough attention I guess, because these aren't actually the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants