Patch: Show join_muc button on logout/relogin

[ChristianTacke]

Version: 3.0.1-beta2/standalone

When logging out using jsxc.xmpp.logout and logging in again using jsxc.gui.showLoginBox the MUC features are basicly broken. Most notably the Join MUC menu item is missing.

The appended patch (applied to the built jsxc.js) seems to fix this mostly for me. Please review carefully!

[ChristianTacke]

Okay, here is the patch. Appending it as a file did not work, for whatever reason.

--- jsxc.js.orig    2016-10-14 15:51:42.000000000 +0200
+++ jsxc.js 2016-10-26 19:49:03.447645252 +0200
@@ -1374,8 +1374,7 @@
       $('#jsxc_windowList').remove();

       if (jsxc.triggeredFromElement) {
-         $(document).trigger('toggle.roster.jsxc', ['hidden', 0]);
-         $('#jsxc_roster').remove();
+         jsxc.gui.roster.shutdown();

          // REVIEW: logoutElement without href attribute?
          if (jsxc.triggeredFromLogout) {
@@ -4019,6 +4018,15 @@
    },

    /**
+    * Shutdown roster
+    */
+   shutdown: function() {
+      $(document).trigger('toggle.roster.jsxc', ['hidden', 0]);
+      $('#jsxc_roster').remove();
+      jsxc.gui.roster.ready = false;
+   },
+
+   /**
     * Create roster item and add it to the roster
     *
     * @param {String} bid bar jid
@@ -7142,7 +7150,7 @@
 $(document).on('init.window.jsxc', jsxc.muc.initWindow);
 $(document).on('add.roster.jsxc', jsxc.muc.onAddRoster);

-$(document).one('attached.jsxc', function() {
+$(document).on('attached.jsxc', function() {
    jsxc.muc.init();
 });

[sualko]

Thank you for your report and patch. I could reproduce your issue, but sadly it will not go into the pending bug fix release, because I am afraid of side effects. So it will find his way into the next release after 3.0.1..

[ChristianTacke]

Thanks for fixing this!