[WIP] Add desktop sharing #438
Conversation
- remove bubbles
| font-style: italic; | ||
|
|
||
| .jsxc_emoticon { | ||
| width: 1.2em; |
There was a problem hiding this comment.
Properties should be ordered height, vertical-align, width
| font-size: 0.8em; | ||
| font-style: italic; | ||
|
|
||
| .jsxc_emoticon { |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
Selector jsxc_emoticon should be written in lowercase with hyphens
| @@ -618,6 +618,15 @@ | |||
| box-sizing: border-box; | |||
| margin-right: 3px; | |||
| border-radius: 3px; | |||
| background-color: transparent; | |||
| font-size: 0.8em; | |||
| font-style: italic; | |||
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| @@ -618,6 +618,15 @@ | |||
| box-sizing: border-box; | |||
| margin-right: 3px; | |||
| border-radius: 3px; | |||
| background-color: transparent; | |||
| font-size: 0.8em; | |||
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| @@ -618,6 +618,15 @@ | |||
| box-sizing: border-box; | |||
| margin-right: 3px; | |||
| border-radius: 3px; | |||
| background-color: transparent; | |||
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| @@ -136,7 +274,7 @@ | |||
| bottom: 10px; | |||
| z-index: 9990; | |||
| background-color: $black; | |||
| cursor: pointer; | |||
| cursor: move; | |||
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| box-shadow: 0 0 10px #a1a1a1; | ||
|
|
||
| .jsxc_localvideo { | ||
| position: static; |
There was a problem hiding this comment.
Properties should be ordered display, position
| background-color: transparent; | ||
| box-shadow: 0 0 10px #a1a1a1; | ||
|
|
||
| .jsxc_localvideo { |
There was a problem hiding this comment.
Selector jsxc_localvideo should be written in lowercase with hyphens
| bottom: auto; | ||
| z-index: 99; | ||
| background-color: transparent; | ||
| box-shadow: 0 0 10px #a1a1a1; |
There was a problem hiding this comment.
Color literals like #a1a1a1 should only be used in variable declarations; they should be referred to via variable everywhere else.
| @@ -54,6 +176,22 @@ | |||
| bottom: 0px; | |||
| background-color: $video_bg; | |||
|
|
|||
| &.jsxc_minimized { | |||
| position: fixed; | |||
There was a problem hiding this comment.
Properties should be ordered background-color, bottom, box-shadow, left, position, right, top, z-index
| @@ -54,6 +176,22 @@ | |||
| bottom: 0px; | |||
| background-color: $video_bg; | |||
|
|
|||
| &.jsxc_minimized { | |||
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
Selector jsxc_minimized should be written in lowercase with hyphens
| margin-left: -50px; | ||
| } | ||
|
|
||
| 35% { |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| margin-left: -30px; | ||
| } | ||
|
|
||
| 30% { |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| margin-left: -50px; | ||
| } | ||
|
|
||
| 25% { |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| margin-left: -30px; | ||
| } | ||
|
|
||
| 20% { |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| margin-left: -50px; | ||
| } | ||
|
|
||
| 15% { |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
|
This pr will not only add screen sharing to jsxc, but also change/update minor parts of the ui. Specially system messages are more reserved now and I added icons to distinct between calls and screen sharing. Also the number of system messages is reduced during a call.
|
| } | ||
| } | ||
|
|
||
| .jsxc_bell:before { |
There was a problem hiding this comment.
Rule set contains (18/10) properties
| $ringingColor1: #98d48f; | ||
| $ringingColor2: #76ba6c; | ||
|
|
||
| .jsxc_ringing:before { |
There was a problem hiding this comment.
Rule set contains (16/10) properties
| $establishingColor1: #a1a1a1; | ||
| $establishingColor2: #f1f1f1; | ||
|
|
||
| .jsxc_establishing:before { |
There was a problem hiding this comment.
Rule set contains (15/10) properties
fix #8
There are some browser limitations for desktop sharing:
TODO
jsxc.lib.webrtc.js