New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archived messages not loading for chat ids containing @ (\40) character #560
Comments
As you can see in #501, JID escaping was requested before, but not implemented yet. So it would be awesome if you could share your enhancement with the community and I could help even you better if I know which changes you did. |
If your organization provides both mail and chat, or if you are in a position to request changes to the mail domain's DNS entries: The XMPP way would be have JID=email address.
|
Thank you for your responses. @MarcelWaldvogel, our organisation does provide mail and chat but we have multiple mail domains and chat is common for all. Eg. user1@example1.com can chat with user2@example2.com @sualko, I am not sure if the changes we made can be integrated here as they are very specific to our project. We have avoided the special character validation as below -
Like you mentioned in #501, using bid instead of jid is probably causing the issue in retrieving archived messages. |
One of the beauties of XMPP is that it works seamless in a federation. It does not matter to a user whether (s)he is
Rosters, MUC, … all work seamlessly across the federation, unless restricted by an admin. I would suggest changing to a single server with a vhost per internal domain, as there are many benefits of having identical mail and XMPP addresses. |
(I fully agree with you that JSXC should be able to deal with JID escaping.) |
I would assume that the jid is not properly escaped at jsxc.lib.xmpp.mam.js#L42 and therefore the resulting stanza is invalid. Try to enable debugging and use |
Hello,
Thank you for creating this library. Message archiving is one of the main chat requirements for our project, so we are very happy to see it included in the latest release. However, facing one issue while loading the message history…
Our requirement is to have chat ids as email ids e.g.. username@example.com@chatserver. While registering on the xmpp server(ejabberd in our case), the ids get created correctly as username\40example.com@chatserver. We made some changes to the jsxc code to enable adding contact in this format and all is working fine. However when clicked on “Load older messages”, nothing appears. With ids without a \40, the archived messages get loaded perfectly fine.
Is it possible to provide support for this requirement? Do let me know if you need any more details.
Thank you.
The text was updated successfully, but these errors were encountered: