-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hint mechanism different in the paper? #2
Comments
In practice, providing 90% of the mask vector as the hints make the best performance. (Hint is only given to the known features) |
Thank you for the quick answer. Besides the convergence question, I still have the doubt about the 0.5. In the paper I understood that the hint was indicating:
And the discriminator has to define if the 0.5 is an original or an inputed value. But in this implementation, the hint shows:
So the hint is only helping in the known original values, but giving no hint about the missing values? |
Yes. |
Usually, on missing completely at random setting, hint does not have a big impact on the results. |
1.The Imputed Matrix is equal to the Hat_New_X? |
|
Thank you for the quick answer.
|
|
In the paper, Figure 1 shows, you feed three matrixes, including data matrix, random matrix, mask matrix, but I do not see you feeding random matrix to the generator. What is the random matrix? |
You can see how we use random matrix in this link (https://github.com/jsyoon0823/GAIN/blob/master/gain.py#L168-L169) |
In the paper the hint mechanism is generated by first selecting one feature by row in a vector called k.
Then a matrix b with the same size of the mask m is created, with a one per row according to k and the rest set to zero.
Then the hint is created with the equation:
h = b * m + 0.5 * (1.0 - b)
Which means that the hint is almost a copy of m but has exactly one 0.5 per row.
In your implementation, the hint is created by removing ones of the mask m with a probability of 0.9 (or a probability of keeping them of 0.1). There are no 0.5 values in the hint.
Am I understanding something wrong?
Thank you.
The text was updated successfully, but these errors were encountered: