Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

about minibatch #39

Closed
GA17AI opened this issue Jul 15, 2023 · 1 comment
Closed

about minibatch #39

GA17AI opened this issue Jul 15, 2023 · 1 comment

Comments

@GA17AI
Copy link

GA17AI commented Jul 15, 2023

Hi, thanks for such innovative ideal open source! However, I have a question: in the code of gain.py, lines 159 to 161, when taking minibatch training, is random, which does not guarantee that all the data is traversed. Why is training not designed to go through all batches in order to complete the training of an epoch？
@jsyoon0823
Copy link
Owner

That is just for implementation simplicity. No other reasons.
You can easily change it as epoch training that guarantees to utilize all samples.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsyoon0823 @GA17AI