Keep watching files imported in sass also when they have errors

[endaaman]

If you build following codes

require('./style.scss');

// style.scss
@import "external";

// _external.scss
.red {
  color: red;
}

and change _external.scss with error such as syntax error like

// _external.scss (missing closing brace)
.red {
  color: red;

then Webpack will not recompile the scss files.

And If you build style.scss importing _external.scss missing closing brace firstly and modify _external.scss, Webpack will also not recompile them.

This PR fixes them.

[jorrit]

There is a console.log(err) in the second commit. Also, can you squash the commits?

[endaaman]

I'm very sorry. Im just an amateur at coding.
You don't have to merge this PR. But please acknowledge the problem...

[jorrit]

Wouldn't it be easier to just do addIncludedFilesToWebpack([err.file]) in both error handlers or am I overlooking something ?

[endaaman]

Do you mean it should be like this?

    // line: 165
    sass.render(opt, function onRender(err, result) {
        if (err) {
            addIncludedFilesToWebpack([err.file]);
            formatSassError(err);
            callback(err);
            return;
        }

If it is so, this does'nt work well.

// style.scss
@import "external";

//  _external.scss
@import "more-external";

// _more-external.scss (missing closing brace)
.red {
  color: red;

If you build this, fail and comment out @import "more-external"; in _external.scss, Webpack will not recompile because Webpack is watching only _more-external.scss and can't detect _external.scss is modified.

[jorrit]

I now see what you mean. It would definitely be easier with squashed commits :) it is not very hard to do, see https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

[jhnns]

Thx for your effort @endaaman. 👍

The current master branch should fix your problem. However, I've used another approach because your PR adds files as dependency that might not exist anymore. This might be no problem, but I don't think that it's good coding style (no offence). But your PR was inspiration for the current solution 😀.

[endaaman]

I just confirmed this problem is fixed! Thanks ;)