Normalize paths of dependencies #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -237,7 +237,7 @@ module.exports = function (content) { | |||
| return result.css.toString(); | |||
| } catch (err) { | |||
| formatSassError(err); | |||
| err.file && this.dependency(err.file); | |||
| err.file && addNormalizedDependency(err.file); | |||
There was a problem hiding this comment.
I don't think that this is necessary. formatSassError is already normalizing it.
|
Could you give me an example where the problem occurs? The paths are already normalized afaik. |
jhnns
added a commit
that referenced
this pull request
Aug 14, 2015
|
Shipped with 2.0.1. Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug where webpack ignores the incremental build and recompile all files in project (win 8.1)