Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resoucePath for custom importers #267

Merged
merged 1 commit into from
Sep 1, 2016
Merged

Use resoucePath for custom importers #267

merged 1 commit into from
Sep 1, 2016

Conversation

chrisfitz
Copy link
Contributor

@jhnns, this should fix custom sass importers by passing resourcePath instead of stdin into the prev argument.

Fixes #234

@jhnns
Copy link
Member

jhnns commented Aug 15, 2016

Thx for your PR. I'm currently on vacation, so please be patient. I'll take a look in the end of August :)

Am 11.08.2016 um 00:13 schrieb Chris Fitzgerald notifications@github.com:

@jhnns, this should fix custom sass importers by passing resourcePath instead of stdin into the prev argument.

Fixes #234

You can view, comment on, or merge this pull request online at:

#267

Commit Summary

Use resoucePath for custom importers
File Changes

M index.js (8)
M test/tools/customImporter.js (3)
Patch Links:

https://github.com/jtangelder/sass-loader/pull/267.patch
https://github.com/jtangelder/sass-loader/pull/267.diff

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@jhnns jhnns merged commit 327de9c into webpack-contrib:master Sep 1, 2016
@jhnns
Copy link
Member

jhnns commented Sep 1, 2016

Awesome, that looks good. Thanks :)

jhnns added a commit that referenced this pull request Sep 1, 2016
@jhnns
Copy link
Member

jhnns commented Sep 1, 2016

Shipped as 4.0.1

This was referenced Sep 1, 2016
This was referenced Sep 7, 2016
@Awk34
Copy link

Awk34 commented Sep 27, 2016

^ lol greenkeeper

@boennemann
Copy link

boennemann commented Oct 2, 2016

Hey all,

Greenkeeper dev here. Got here via this tweet: https://twitter.com/Jhnnns/status/782528090186588160

Sorry for this "referencing spam". We trying to avoid this, by rewriting all links in our Pull Requests leading to GitHub to our own service ("urls.greenkeeper.io"), which redirects to GitHub again, but without triggering a reference.

It looks like you've used the <user>/<repo>#<issue> short form in one of your commit messages, which is causing the reference. It sure looks like we're not handling this case properly yet.

I've opened an issue on that and I hope we can close it soon greenkeeperio/greenkeeper#305

Sorry for the inconvenience.

Best,
Stephan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need resourcePath in custom importer
4 participants