Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trait impl fallbacks for non-floats #10

Closed
jtempest opened this issue Jun 9, 2020 · 1 comment
Closed

Trait impl fallbacks for non-floats #10

jtempest opened this issue Jun 9, 2020 · 1 comment

Comments

@jtempest
Copy link
Owner

jtempest commented Jun 9, 2020

In particular for types like Result or composite types that contain non-floats, it makes sense to introduce a path for non-floats to be considered in floating point equality expressions. Consider how to sensibly do this - diffs should be None and equality should defer to PartialEq.
This was referenced Jun 9, 2020
Closed
Closed
@jtempest jtempest changed the title FloatEq over non-floats Trait impl fallbacks for non-floats Jun 12, 2020
@jtempest jtempest added enhancement New feature or request and removed enhancement New feature or request labels Jun 12, 2020
@jtempest
Copy link
Owner Author

Closed as vague, will be replaced by more specific discussion of what to do wrt enums (in particular Result).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtempest