Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make $plugin_dir absolute path #63

Merged
merged 5 commits into from
Aug 30, 2022
Merged

Conversation

janaaronlee
Copy link
Contributor

Description

Changed $plugin_dir from relative path to absolute path.

Motivation and Context

Recent changes in asdf-direnv broke compatibility with asdf-gcloud. Whenever direnv tried to load gcloud, it would display the following error:

direnv: using asdf gcloud 392.0.0
direnv: loading ~/.asdf/plugins/gcloud/bin/exec-env
./exec-env:9: ./lib/utils.bash: No such file or directory

Changing $plugin_dir from relative path to absolute path in exec-env fixes this issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Usage examples

Same as before.

How Has This Been Tested?

Checklist:

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@janaaronlee janaaronlee changed the title Changed $plugin_dir from relative path to absolute path fix: changed $plugin_dir from relative path to absolute path Jul 6, 2022
bin/exec-env Outdated Show resolved Hide resolved
@nklmilojevic
Copy link
Contributor

This PR also solves this #64

@jthegedus
Copy link
Owner

Hi all, thanks for the feedback. I am going to merge this. I am still not sure why this is needed here and not for all other plugins. Nor do I like the fact it does a cd subshell where previously things have worked fine. I don't use asdf-direnv and don't want to go down the investigation rabbit hole. Thanks again, lets hope this fixes all for everyone.

@jthegedus jthegedus changed the title fix: changed $plugin_dir from relative path to absolute path fix: make $plugin_dir absolute path Aug 30, 2022
@jthegedus jthegedus merged commit 6b9e673 into jthegedus:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants