Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#169): Replace installFetch() with installPolyfills() #170

Merged
merged 6 commits into from
Jun 8, 2022

Conversation

pham
Copy link
Contributor

@pham pham commented May 24, 2022

Summary

Replace src/files/shims.js with the polyfills version.

Fixes: #169

@jthegedus
Copy link
Owner

Thanks

@eXodes
Copy link

eXodes commented Jun 6, 2022

@jthegedus Hi James, is this going to be merged anytime soon?

@koreypeters-dexcom
Copy link

Would love to see this merged as well.

@Nushio
Copy link
Collaborator

Nushio commented Jun 7, 2022

Hi Pham,

I've tested your changes on my sveltekit project and it's working fine. I also went ahead and fixed the integration tests that are currently failing, but I'm not sure how to push the commit onto this PR.
Nushio@d356444

I'd like to release the latest version of svelte-adapter-firebase with my fixes on Windows, your polyfills change, and co3k's header's pr (with a minor fix) as version 0.15.0 this week, if there are no objections / issues.

@pham
Copy link
Contributor Author

pham commented Jun 7, 2022

Hi Pham,

I've tested your changes on my sveltekit project and it's working fine. I also went ahead and fixed the integration tests that are currently failing, but I'm not sure how to push the commit onto this PR. Nushio@d356444

I'd like to release the latest version of svelte-adapter-firebase with my fixes on Windows, your polyfills change, and co3k's header's pr (with a minor fix) as version 0.15.0 this week, if there are no objections / issues.

Nushio,
If you'd create a pull request on my fork with your changes, I'll merge it and hopefully, that will get updated here.

@Nushio
Copy link
Collaborator

Nushio commented Jun 8, 2022

Done!
pham#2

@pham pham requested a review from jthegedus June 8, 2022 04:29
Copy link
Collaborator

@Nushio Nushio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Nushio Nushio merged commit 9c44f0c into jthegedus:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: @sveltejs/kit/install-fetch replaced in @sveltejs/kit 1.0.0-next.341
5 participants