-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#169): Replace installFetch()
with installPolyfills()
#170
Conversation
…s/kit/node/polyfills
Thanks |
@jthegedus Hi James, is this going to be merged anytime soon? |
Would love to see this merged as well. |
Hi Pham, I've tested your changes on my sveltekit project and it's working fine. I also went ahead and fixed the integration tests that are currently failing, but I'm not sure how to push the commit onto this PR. I'd like to release the latest version of svelte-adapter-firebase with my fixes on Windows, your polyfills change, and co3k's header's pr (with a minor fix) as version 0.15.0 this week, if there are no objections / issues. |
Nushio, |
Done! |
fix: integration tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Summary
Replace
src/files/shims.js
with the polyfills version.Fixes: #169